Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HP Omen theme #133

Merged
merged 5 commits into from
May 18, 2024
Merged

Conversation

jaherron
Copy link
Contributor

@jaherron jaherron commented May 4, 2024

Description

I added an image in the backgrounds folder for HP Omen, and ran the Actions workflow. An entry for this theme was also added in the themes.json file, but I don't know where it should have gone so I put it below the one for generic HP.

I wanted to make this contribution since I recently got an Omen laptop and I like using these themes for when I install distros that don't come with a GRUB theme.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (correct file and folder structure)
  • The background image for theme follows naming convention: theme_name.png
  • I updated themes.json file (JSON database)

themes.json Outdated Show resolved Hide resolved
themes.json Show resolved Hide resolved
@jaherron jaherron requested a review from AdisonCavani May 4, 2024 22:12
@AdisonCavani AdisonCavani merged commit 08c7b2d into AdisonCavani:master May 18, 2024
72 checks passed
@jaherron jaherron deleted the jaherron-patch-1 branch May 23, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants