Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nix flake #132

Merged
merged 10 commits into from
Apr 17, 2024
Merged

feat: add nix flake #132

merged 10 commits into from
Apr 17, 2024

Conversation

zakuciael
Copy link
Contributor

Description

This PR adds a new installation method for NixOS users by adding a flake.nix file.
It also adds a new GitHub action that automatically checks if the nix configuration is valid, and that the packages can be built.
The Flake requires no additional updates from maintainers as it gathers all themes located under the assets/backgrounds/ folder and builds them automatically.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I've updated the documentation to reflect the changes.

Copy link
Owner

@AdisonCavani AdisonCavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!
Thank you for your contribution.
Please move the files into build folder (nix related).

@zakuciael zakuciael requested a review from AdisonCavani April 16, 2024 14:19
@zakuciael
Copy link
Contributor Author

I've moved the files to the build/ directory. But I've left the flake.nix and flake.lock in the root. Otherwise, it adds extra steps when installing the flake on NixOS and it is a standard in Nix community to add it to the root of the repository.

@AdisonCavani AdisonCavani merged commit 56b8ea8 into AdisonCavani:master Apr 17, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants