Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'trusted-click-element' — fix click on page layout elements #437

Closed
alexx7311 opened this issue Jul 18, 2024 · 0 comments
Closed

Improve 'trusted-click-element' — fix click on page layout elements #437

alexx7311 opened this issue Jul 18, 2024 · 0 comments
Assignees
@jellizaveta
Labels
bug Something isn't working Priority: P4 Release: v1.11.16 Resolution: Fixed Status: Closed Version: Scriptlets v1.11

Comments

@alexx7311
Copy link

STR:

  1. Add adguardteam.github.io#%#//scriptlet('trusted-click-element', 'button[id="redirectButton"]') to the User rules
  2. Go to https://adguardteam.github.io/AnonymousRedirect/redirect.html?url=https%3A%2F%2Fogrodosfera.pl%2F
Screenshot

Screenshot

The rule is displayed in the filtering log, but it doesn't click 'TAKE ME THERE' button.
Reproduced in 4.3.53 and 4.4.1 beta extensions in Chrome 126 incognito mode.
@adguard-bot adguard-bot added Priority: P4 bug Something isn't working labels Jul 18, 2024
@adguard-bot adguard-bot assigned jellizaveta and unassigned maximtop Jul 23, 2024
adguard pushed a commit that referenced this issue Jul 23, 2024
@jellizaveta
AG-34532 Improve 'trusted-click-element' scriptlet — fix click on pag…
6bc3ed5 
…e layout elements. #437
adguard pushed a commit that referenced this issue Jul 25, 2024
@jellizaveta
AG-34532 Improve 'trusted-click-element' scriptlet — fix click on pag…
50cabb2 
…e layout elements. #437

Squashed commit of the following:

commit 722b946
Merge: 46f05ef 2b397e1
Author: jellizaveta <[email protected]>
Date:   Thu Jul 25 13:23:31 2024 +0300

    Merge branch 'fix/AG-34532' of ssh://bit.int.agrd.dev:7999/adguard-filters/scriptlets into fix/AG-34532

commit 46f05ef
Merge: 7cabd76 3b500cf
Author: jellizaveta <[email protected]>
Date:   Thu Jul 25 13:23:07 2024 +0300

    Merge branch 'master' into fix/AG-34532

commit 2b397e1
Author: Slava Leleka <[email protected]>
Date:   Wed Jul 24 18:48:07 2024 +0300

    src/scriptlets/trusted-click-element.ts edited online with Bitbucket

commit ebaa27e
Author: Slava Leleka <[email protected]>
Date:   Wed Jul 24 18:48:00 2024 +0300

    CHANGELOG.md edited online with Bitbucket

commit d986149
Author: Slava Leleka <[email protected]>
Date:   Wed Jul 24 18:47:49 2024 +0300

    src/scriptlets/trusted-click-element.ts edited online with Bitbucket

commit 7cabd76
Author: jellizaveta <[email protected]>
Date:   Wed Jul 24 13:25:06 2024 +0300

    fix the click function of already existing elements in the DOM

commit 99eb37d
Author: jellizaveta <[email protected]>
Date:   Tue Jul 23 18:40:13 2024 +0300

    fix the case when one element is added before the scriptlet and the rest after

commit 62fe248
Author: jellizaveta <[email protected]>
Date:   Tue Jul 23 17:55:04 2024 +0300

    update tests and changelog

commit 6bc3ed5
Author: jellizaveta <[email protected]>
Date:   Tue Jul 23 15:30:21 2024 +0300

    AG-34532 Improve 'trusted-click-element' scriptlet — fix click on page layout elements. #437
@adguard-bot adguard-bot changed the title 'trusted-click-element' doesn't work in the Chrome extension Improve 'trusted-click-element' scriptlet — fix click on page layout elements Aug 1, 2024
@adguard-bot adguard-bot changed the title Improve 'trusted-click-element' scriptlet — fix click on page layout elements Improve 'trusted-click-element' — fix click on page layout elements Aug 1, 2024
This was referenced Aug 2, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jellizaveta jellizaveta

Labels
bug Something isn't working Priority: P4 Release: v1.11.16 Resolution: Fixed Status: Closed Version: Scriptlets v1.11
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximtop @adguard-bot @jellizaveta @alexx7311