Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'json-prune' — stack #348

Closed
AdamWr opened this issue Aug 2, 2023 · 0 comments
Closed

Improve 'json-prune' — stack #348

AdamWr opened this issue Aug 2, 2023 · 0 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Aug 2, 2023

It seems that currently stack parameter doesn't work correctly, it's checked at the beginning of the scriptlet, not during pruning, so it's from scriptlet itself (if I'm not wrong):

export function jsonPrune(source, propsToRemove, requiredInitialProps, stack) {
if (!!stack && !matchStackTrace(stack, new Error().stack)) {
return;
}

@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop Aug 2, 2023
adguard pushed a commit that referenced this issue Aug 10, 2023
Squashed commit of the following:

commit 38f0da2
Author: Slava Leleka <[email protected]>
Date:   Thu Aug 10 13:22:40 2023 +0300

    Update test description

commit 4c9356b
Author: Slava Leleka <[email protected]>
Date:   Thu Aug 10 13:22:08 2023 +0300

    Update test description

commit 15b3d7c
Merge: 0e3b35c 1b81a02
Author: Adam Wróblewski <[email protected]>
Date:   Thu Aug 10 11:08:30 2023 +0200

    Merge branch 'master' into fix/AG-24527

commit 0e3b35c
Merge: 31d149d 975ad11
Author: Adam Wróblewski <[email protected]>
Date:   Fri Aug 4 14:49:41 2023 +0200

    Merge branch 'master' into fix/AG-24527

commit 31d149d
Author: Adam Wróblewski <[email protected]>
Date:   Thu Aug 3 16:24:50 2023 +0200

    Fix issue with stack and obligatoryProps in json-prune
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants