-
Notifications
You must be signed in to change notification settings - Fork 331
[AG-31991] Remove complicated heuristics for $domain modifier #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
@workingBanana We need to retain info about deprecated behavior, but note that since CoreLibs 1.18 logic is simplified. Examples should mention both cases, though. |
sfionov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented separately
Now that we have the `$to` modifier, `$domain` will no longer match the target domain by default - only when the `$csp` or `$cookie` modifiers are specified. See-also: AG-31991 Signed-off-by: Alexey Zhavoronkov <[email protected]>
137d503 to
83eaea6
Compare
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
sfionov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add $removeparam
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
sfionov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
Co-authored-by: Helen <[email protected]>
Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
2 similar comments
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/ |
Now that we have the
$tomodifier,$domainwill no longer match the target domain by default - only when the$cspor$cookiemodifiers are specified.Target CoreLibs version is 1.18