Skip to content

Conversation

@workingBanana
Copy link
Contributor

@workingBanana workingBanana commented Apr 4, 2025

Now that we have the $to modifier, $domain will no longer match the target domain by default - only when the $csp or $cookie modifiers are specified.
Target CoreLibs version is 1.18

@github-actions
Copy link

github-actions bot commented Apr 4, 2025

Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/

@sfionov
Copy link
Member

sfionov commented Apr 11, 2025

@workingBanana We need to retain info about deprecated behavior, but note that since CoreLibs 1.18 logic is simplified. Examples should mention both cases, though.

Copy link
Member

@sfionov sfionov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented separately

Now that we have the `$to` modifier, `$domain` will no longer match the target domain
by default - only when the `$csp` or `$cookie` modifiers are specified.

See-also: AG-31991
Signed-off-by: Alexey Zhavoronkov <[email protected]>
@github-actions
Copy link

Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/

@github-actions
Copy link

github-actions bot commented May 5, 2025

Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/

@github-actions
Copy link

Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/

Copy link
Member

@sfionov sfionov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add $removeparam

@github-actions
Copy link

Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/

@sfionov sfionov self-requested a review August 12, 2025 07:38
Copy link
Member

@sfionov sfionov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions
Copy link

Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/

@sfionov sfionov requested a review from el-termikael August 12, 2025 18:30
@github-actions
Copy link

Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/

2 similar comments
@github-actions
Copy link

Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/

@github-actions
Copy link

Preview was deployed to: https://pull-request-677.kb-adg.pages.dev/

@workingBanana workingBanana merged commit dcc89af into master Sep 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants