Add description for attributes without value in selector for html filtering rules #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview was deployed to: https://pull-request-634.kb-adg.pages.dev/ |
slavaleleka
reviewed
Jan 16, 2025
Contributor
slavaleleka
left a comment
slavaleleka
left a comment
There was a problem hiding this comment.
Target CoreLibs version is 1.18
it should be mentioned in the compatibility note
slavaleleka
reviewed
Jan 16, 2025
Co-authored-by: Slava <[email protected]> Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-634.kb-adg.pages.dev/ |
1 similar comment
|
Preview was deployed to: https://pull-request-634.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-634.kb-adg.pages.dev/ |
slavaleleka
reviewed
Jan 28, 2025
slavaleleka
approved these changes
Jan 28, 2025
Co-authored-by: Helen <[email protected]>
el-termikael
approved these changes
Feb 19, 2025
|
Preview was deployed to: https://pull-request-634.kb-adg.pages.dev/ |
1 similar comment
|
Preview was deployed to: https://pull-request-634.kb-adg.pages.dev/ |
el-termikael
reviewed
Jun 5, 2025
Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-634.kb-adg.pages.dev/ |
maximtop
approved these changes
Jun 6, 2025
sfionov
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target CoreLibs version is 1.18
related:
AdguardTeam/CoreLibs#1934
AdguardTeam/tsurlfilter#147