Adding AdGuard Quick Fixes
#993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonya-orlova
approved these changes
Aug 27, 2024
Alex-302
requested changes
Aug 27, 2024
Co-authored-by: Alex <[email protected]>
Alex-302
requested changes
Aug 27, 2024
Alex-302
approved these changes
Aug 27, 2024
vozersky
approved these changes
Aug 27, 2024
slavaleleka
reviewed
Aug 27, 2024
slavaleleka
reviewed
Aug 27, 2024
Alex-302
approved these changes
Aug 27, 2024
slavaleleka
reviewed
Aug 27, 2024
zloyden
requested review from
slavaleleka,
sonya-orlova,
vozersky,
ameshkov and
a team
slavaleleka
approved these changes
Aug 30, 2024
Alex-302
reviewed
Aug 30, 2024
| @@ -91,6 +91,10 @@ | |||
| "filter.23.name": "AdGuard Ukrainsk filter", | |||
| "filter.23.description": "Filter, der muliggør adblocking på ukrainsksprogede websteder." | |||
| }, | |||
| { | |||
| "filter.24.name": "AdGuard Quick Fixes-filter", | |||
There was a problem hiding this comment.
Error?
Suggested change
| "filter.24.name": "AdGuard Quick Fixes-filter", | |
| "filter.24.name": "AdGuard Quick Fixes filter", |
There was a problem hiding this comment.
nope, a hyphen is needed here I guess
There was a problem hiding this comment.
why not used in similar phrases of this lang?
locales/de/filters.json
Outdated
| @@ -91,6 +91,10 @@ | |||
| "filter.23.name": "AdGuard Ukrainischer Filter", | |||
| "filter.23.description": "Filter, der Anzeigen auf ukrainischen Webseiten sperrt." | |||
| }, | |||
| { | |||
| "filter.24.name": "Quick Fixes-Filter", | |||
There was a problem hiding this comment.
Error?
Suggested change
| "filter.24.name": "Quick Fixes-Filter", | |
| "filter.24.name": "AdGuard Quick Fixes Filter", |
There was a problem hiding this comment.
if so, should be fixed in crowdin
There was a problem hiding this comment.
fixed in crowdin, but a hyphen is also needed
There was a problem hiding this comment.
@BlazDT Is it correct for German?
AdamWr
reviewed
Aug 30, 2024
Alex-302
approved these changes
Aug 30, 2024
sonya-orlova
approved these changes
Aug 30, 2024
|
We are ready to merge. |
vozersky
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to AdguardTeam/AdguardFilters#187308