-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude ##.adsbygoogle #729
Conversation
I guess it's By the way, now I have noticed that also So maybe it also should be - |
Now I think of, there can theoretically be this type of specific filter: |
That's a good point, but if I'm not wrong, it will not cover all cases.
will be okay (https://regex101.com/r/LLqMr0/1), but I'm still not sure if all cases will be catched. |
/^(~.*)?###banner_ad$/ | ||
/^(~.*)?##\.adsbox$/ | ||
/^(~.*)?##\.afs_ads$/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why changed? /^##
was enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can there be harm? Some filter may add ~foo.com##.afs_ads
in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
For easylist/easylist@c09ae08
BTW isn't
^
needed for/###banner_ad$/
as well? Specific###banner_ad
may be used by good reason.