Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes no filtering on Google related sites (e.g. youtube.com) #4480

Closed
Alex-302 opened this issue Nov 14, 2022 · 41 comments
Closed

Sometimes no filtering on Google related sites (e.g. youtube.com) #4480

Alex-302 opened this issue Nov 14, 2022 · 41 comments

Comments

@Alex-302
Copy link
Member

Alex-302 commented Nov 14, 2022

Original problem: AdguardTeam/AdguardFilters#132759 (comment)

Weird. Please make screenshot of the cetrificate when a banner is not blocked.
Here:
https://imgur.com/a/iN2Ne7S
Another one:
https://imgur.com/a/ttbEI0V

@tnt838 Moved your issue here

@Alex-302 Alex-302 added the bug label Nov 14, 2022
@Aydinv13
Copy link

@tnt838 Could you please collect trace logs for us?

  1. Stop AdGuard. Please don't leave the service running. Screen
  2. Open the console (type cmd in the start panel).
  3. Run the app with the command C:\"Program Files (x86)"\Adguard\Adguard.exe /trace if you are using 64-bit Windows, and C:\"Program Files"\Adguard\Adguard.exe /trace in case if you use 32-bit one.
  4. Select Debug logging level. Screen
  5. Reproduce the issue. We strongly advise to specify the time when you reproduced the issue: it will help our support team to solve the problem.
  6. Export the recorded logs using the Export Log button.
  7. Set the logging level back to Standard. Debug logging level may slow down the application.
  8. Send the archive to [email protected]

@Alex-302
Copy link
Member Author

Similar report:
AdguardTeam/AdguardFilters#135534 (comment)
and a comment
AdguardTeam/AdguardFilters#135534 (comment)

@ORI123456 Could you please collect logs as described here?
#4480 (comment)

@ORI123456
Copy link

ORI123456 commented Nov 29, 2022

Similar report: AdguardTeam/AdguardFilters#135534 (comment) and a comment AdguardTeam/AdguardFilters#135534 (comment)

@ORI123456 Could you please collect logs as described here? #4480 (comment)

I'll try but it will take some time because it's not happening every day

@ORI123456

This comment was marked as duplicate.

@ORI123456
Copy link

ORI123456 commented Dec 7, 2022

Similar report: AdguardTeam/AdguardFilters#135534 (comment) and a comment AdguardTeam/AdguardFilters#135534 (comment)

@ORI123456 Could you please collect logs as described here? #4480 (comment)

@Alex-302 I sent a log yesterday. Do I need to send more?

@Aydinv13
Copy link

Aydinv13 commented Dec 7, 2022

@ORI123456 there is no need to send more. Thank you.

@Aydinv13
Copy link

@ORI123456
We've made a few updates, could you test the latest nightly build?

@ORI123456
Copy link

@ORI123456 We've made a few updates, could you test the latest nightly build?
I just now checked here and saw your post.
and i have a Q how i'm suppose to know if it fixed it. There's no clear way to know if it's fixed or not unless I wait at least a month or two without it happening even once

@gork7777
Copy link

@ORI123456 Just you need to test while you surfing on the YouTube.

@ORI123456
Copy link

@ORI123456 Just you need to test while you surfing on the YouTube.

Just surfing isn’t indication, because that bug happing sometimes and not all the time. So unless a lot of time have passed without an issue, I don’t have any means to test it.

@ORI123456
Copy link

ORI123456 commented Dec 22, 2022

@ORI123456 We've made a few updates, could you test the latest nightly build?

From the time i start using the nightly build i have a lot of problems with the speed of the surfing. a lot of pages takes like 70% more time to load and i'm using Ethernet with about 600mb download speed.
And sometimes i'm getting error when the site failing to load.
See that video:
https://youtu.be/WrkDkHFULy0
And in addition it affects online video players like MP4UPLOAD that doesn't Load or taking a lot of time to load until you can play the video. a Lot of loading in the middle of a video. And also, videos on YouTube automatically lower the viewing quality for me as if my internet is too slow.

I'm sorry but i can't stay with that nightly verion. i'm getting back to the stable version.

As for YouTube, for now, no advertisements have appeared

@Aydinv13
Copy link

@ORI123456

Hi again! I'm sorry for the late reply.
The video you provided isn't available. Also this is another problem, could you please create a new issue in this repository so we could work on it.
As for current issue, I'm gonna close it due to no relevance.

Thank you!

@Alex-302
Copy link
Member Author

More strange cases here: AdguardTeam/AdguardFilters#136983 (comment)

@Alex-302
Copy link
Member Author

Alex-302 commented Jan 4, 2023

@ghost
Copy link

ghost commented Feb 4, 2023

Latest Google Chrome stable on latest Windows 11 Pro

@ORI123456
Copy link

Latest Google Chrome stable on latest Windows 11 Pro

Try in on edge and see if you have the problem?

@ghost
Copy link

ghost commented Feb 4, 2023

Just opened edge and still saw ads on youtube. I also added the adguard assistant app to edge (not sure if that is required for blocking or not) and still saw the ads.

Interestingly enough, the ads don't appear until I log into a google account on youtube. Seems like this might be some kind of strange change on Google/YouTube's end.

@ORI123456
Copy link

ORI123456 commented Feb 4, 2023

Just opened edge and still saw ads on youtube. I also added the adguard assistant app to edge (not sure if that is required for blocking or not) and still saw the ads.

Interestingly enough, the ads don't appear until I log into a google account on youtube. Seems like this might be some kind of strange change on Google/YouTube's end.

I'm really don't understand it. I'm logged in and nothing appears In my end not on edge and not on chrome. It's something in your machine that interfering with adguard probably

@northis
Copy link
Member

northis commented Feb 17, 2023

@khaosmaou what certificate do you have when the ads appear on Youtube?
In order to block the ads, the certificate should be issued by AdGuard.
image

@ghost
Copy link

ghost commented Feb 20, 2023

I just got home from a long vacation and saw these replies.

I'll double check everything, including the certificate and let you guys know soon. I'll give it a day or so of random YouTube browsing and see if I still have the issue. There is also a pending AdGuard nightly update I will try as well.

@ghost
Copy link

ghost commented Mar 10, 2023

The certificate clearly shows as being from AdGuard, and I have even recently tried Adguard on an brand new computer with clean settings. Somehow ads continue to get through. It still only happens on YouTube.

I have also purchased a brand new router and started doing encrypted DNS to NextDNS instead of using public dns and the issue persists. There is something going on with AdGuard and chromium based browsers that results in these ads being displayed, as the issue occurs in the latest Edge on Win 11 pro as well.

@ghost
Copy link

ghost commented Mar 10, 2023

Also, if I try both chromium browser and brave browser with it's built in ad-blocking disabled, both of those browsers get NO YouTube ads. It is only an issue with Edge and Chrome. AdGuard appears to be working fine, just certain Chromium browsers have the issue.

@ORI123456
Copy link

ORI123456 commented Mar 12, 2023

Also, if I try both chromium browser and brave browser with it's built in ad-blocking disabled, both of those browsers get NO YouTube ads. It is only an issue with Edge and Chrome. AdGuard appears to be working fine, just certain Chromium browsers have the issue.

What is the adguard version you are using?
If it is version 7.12 then try to update filters manually and see if it is updating or getting errors

@ghost
Copy link

ghost commented Mar 14, 2023

Currently on 7.12 after the clean install. A manual filter updated worked perfectly.

@thespbgamer
Copy link

thespbgamer commented Mar 17, 2023

Edit: I wanna say, I had the exact same issue, with the nightly version the problem was fixed that same day, next day, same issue.
Edit 2: The fix I found was a to clear all the browser's cache, that did the trick (at least for now).

@northis
Copy link
Member

northis commented Mar 30, 2023

There are some issues with Google related sites (like Youtube) and how Chrome works with the QUIC protocol on them.

  1. Chrome may cache QUIC connections, which may result in no filtering on these sites. To fix this, you can manually restart Chrome or type chrome://restart in the address bar.
  2. The original site certificate may be cached for some time after AdGuard protection is launched. Restarting Chrome may not help here. To make sure the AdGuard certificate is being used, you can check the AdGuard Assistant, if it says that protection is enabled for this site.

UPD.

  1. This also can be proactively fixed by turning off QUIC
    Chrome: chrome://flags/ -> Experimental QUIC protocol -> Disable;
    FireFox: about:config -> network.http.http3.enable -> false.

@northis
Copy link
Member

northis commented Mar 31, 2023

@thespbgamer @khaosmaou @ORI123456 @ILIKECHICKENTOOMUCH @goodjohnjr @tnt838
You can check out the previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants