Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd #172178 #174141

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Upd #172178 #174141

merged 2 commits into from
Mar 7, 2024

Conversation

Yuki2718
Copy link
Collaborator

@Yuki2718 Yuki2718 commented Mar 5, 2024

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

#172178

Add your comment and screenshots

  1. Your comment

AdguardTeam/Scriptlets#410

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

@Yuki2718
Copy link
Collaborator Author

Yuki2718 commented Mar 5, 2024

I thought Opera doesn't allow JS rule unless it's built-in. Should I add !adguard_ext_opera too? Applying the set-constant rule alone causes error.

@AdamWr
Copy link
Member

AdamWr commented Mar 5, 2024

As far as I know, extension for Opera couldn't update JS rules in the past, but now it can.

@Alex-302 Alex-302 merged commit 0e42d52 into master Mar 7, 2024
2 checks passed
@Yuki2718 Yuki2718 deleted the Upd_#172178 branch March 7, 2024 16:04
Yuki2718 added a commit that referenced this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants