Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Fix "Floating Dependencies" tests #841

Closed
wants to merge 1 commit into from

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Nov 2, 2020

Pin whatwg-fetch dependency to '3.3.1'.

This fixes an error fetch is not defined - maybe your browser targets are not covering everything you need?
that shows up when running the tests for the floating dependencies stage.

That error comes from ember-fetch, see ember-cli/ember-fetch#547

Pin whatwg-fetch dependence to '3.3.1'.

This fixes an error "fetch is not defined - maybe your browser targets are not covering everything you need?"
that shows up when running the tests for the floating dependencies stage.

That error comes from ember-fetch, see ember-cli/ember-fetch#547
@bantic bantic force-pushed the bantic/fix-v2-floating-deps-tests branch from d181977 to 6019990 Compare November 2, 2020 21:09
@bantic bantic changed the title Bantic/fix v2 floating deps tests [tests] Fix "Floating Dependencies" tests Nov 2, 2020
@mixonic
Copy link
Member

mixonic commented Jan 10, 2021

Closing in favor of 3.0-beta #831

@mixonic mixonic closed this Jan 10, 2021
@mixonic mixonic deleted the bantic/fix-v2-floating-deps-tests branch January 10, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants