Update test rowcount when collapse state changes #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
changed the title
mixonic
force-pushed
the
mixonic/rowcount-fix
branch
from
83b2a69 to
7e75821
Compare
The row count did not update when the collapse of a tree was toggled. Here ensure that happens with an observer in dev mode. Fixes Addepar#804
mixonic
force-pushed
the
mixonic/rowcount-fix
branch
from
7e75821 to
6503b3e
Compare
Member
Author
|
Merging based on prior approval via #805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #804
Based on and replaces #803
Replaces #805
The test rowcount did not update when collapse is triggered. Here do that, but via an observer in non-production builds only.