Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ember-test-selectors #13

Closed
wants to merge 1 commit into from
Closed

Update ember-test-selectors #13

wants to merge 1 commit into from

Conversation

bertdeblock
Copy link

No description provided.

@bantic
Copy link
Member

bantic commented Sep 28, 2021

@bertdeblock thanks for the PR!
The CI failure here seems to be unrelated, but I would like to get it green again before merging anything.
I'll add to my list to take a look. I think that newer ember-beta (which is now Ember v4) is constructed in a way that the tests aren't anticipating. For instance, it removes window.Ember in emberjs/ember.js#19678, and that seems to be the source of one of those errors.

@bertdeblock
Copy link
Author

@bantic No problem! I was also planning on looking at what went wrong here, but haven't had the time yet.

@bertdeblock bertdeblock mentioned this pull request Sep 29, 2021
Closed
@bertdeblock
Copy link
Author

Closing in favour of #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertdeblock @bantic