BILLING-2504: Allow buck to run tests on nested test classes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealryan
reviewed
Jan 23, 2025
| return mightBeJunit5TestClass(c); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This might be a good time to include @TestFactory too
There was a problem hiding this comment.
I think tbh given the magnitude of editing buck, I'll leave that until it's required! (Unless it's required right now?) I'm a bit apprehensive about editing / testing this whole lot
ztai-add
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests, buck looks for the @test annotation on one or more methods.
JUnit 5 provides the @nested annotation to group tests within a class. This is useful for testing methods of a class, allowing them to have dedicated setup, teardown and custom methods. Additionally JUnit groups the tests in the output.
When running a file with only @tests within @nested classes, buck will not run the test file. It will do this silently. This PR forces buck to also look into @nested classes for methods annotated with @test to determine whether the file is a test file or not.