[buck] enable junit5 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottlee14
force-pushed
the
scott/junit5-support
branch
3 times, most recently
from
f91ddee to
71f0347
Compare
|
surprisingly easy. can you swap it for 5.10.1 version of junit? should be a drop-in replacement. |
|
Is there a major benefit to 5.10.1? It's pretty tedious to download JARs from maven for like 5 different dependencies. But I'll do it if there's a good reason. |
|
bug fix around beforeall and beforeach between test inheritance across packages. it hurts us especially since we have cross-package test inheritance. |
That's a good reason. Will do. |
scottlee14
force-pushed
the
scott/junit5-support
branch
from
71f0347 to
d9d02dc
Compare
calcwu
reviewed
Nov 14, 2023
| jUnitCore.run(request); | ||
| } else if (mightBeJunit5TestClass(testClass)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables junit5 on addebuck. This is accomplished by
I also added some changes to
.idea/to facilitate developing with buck at addepar. At this point, addebuck is as tightly coupled with Addepar as it will ever be.@navkast @calcwu