Add color picker component CSS #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estelle
reviewed
May 25, 2018
public/assets/images/empty_color.svg
Outdated
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <!-- Generator: Adobe Illustrator 17.1.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> | |||
There was a problem hiding this comment.
Run SVG's thru https://jakearchibald.github.io/svgomg/ to minimize byte size. It will remove anything unneeded, like the Adobe credit.
estelle
reviewed
May 25, 2018
| @@ -48,8 +49,7 @@ | |||
| // Pressed state | |||
| &:active, | |||
| &.is-active, // the .is-active class is to be used when the button needs to be manually pressed, like for dropdowns | |||
| .open &.dropdown-toggle, // TODO: remove this once dropdowns are replaced in iverson | |||
| &.ice-dropdown-toggle.is-open { | |||
| .open &.dropdown-toggle { // TODO: remove this once dropdowns are replaced in iverson | |||
There was a problem hiding this comment.
Are we keeping a list of these, or should we create a few "codes" to add to comments so we can easily find what we're looking for when it's time to do this?
There was a problem hiding this comment.
Keeping a list might be too tedious I think, easy to forget to update the list, etc.
But I've just been using "TODO:" so I can search that later. If you want to come up with codes thats fine. If its an ember version change I usually do "TODO: Ember 1.13" etc for example.
|
Just need to remove unneeded chars in the SVGs. Otherwise, LGTM
also added a comment about capturing future TO DOs.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as well as misc fiddly bits needed by color picker
I integrated pieces needed to make up the color picker out into the system.
As I did this, I rearranged things a little bit more from the last big rearrangement.
Ignore the temporary caret, its only for the forms sandbox. Font awesome isn't in the system so I had to put something there for demo.
Default
Transparent option
Remove color option (the remove icon is temp in sandbox, will show as trash icon in iverson)
@Addepar/web-core