Update VS code problem matcher for style messages

[patricknoffke]

I have style checks enabled with my compilation flags, which results in messages like:

filename.adb:514:80: (style) this line is too long

These are mapped to errors in VS code using the $ada problemMatcher. Can you please update the matcher to map these to warnings or info? The code below does this, but I have to replicate it for every task. It would be nice to have it defined in the extension.

		{
			"base": "$ada",
			"severity": "warning",
			"pattern": {
				"regexp": "^([^:]:?[^:]*):(\\d+):(\\d+):\\s+(warning|)(?:[:]\\s+)?(.*)$",
				"file": 1,
				"line": 2,
				"column": 3,
				"message": 5
			}
		},
		{
			"base": "$ada",
			"severity": "warning",
			"pattern": {
				"regexp": "^([^:]:?[^:]*):(\\d+):(\\d+):\\s+(style|)(?:[:]\\s+)?(.*)$",
				"file": 1,
				"line": 2,
				"column": 3,
				"message": 5
			}
		},
		{
			"base": "$ada",
			"severity": "error",
			"pattern": {
				"regexp": "^([^:]:?[^:]*):(\\d+):(\\d+):\\s+(error|)(?:[:]\\s+)?(.*)$",
				"file": 1,
				"line": 2,
				"column": 3,
				"message": 5
			}
		}

[patricknoffke]

Here is an updated problemMatcher that maps style checks to info and fixes the mapping of warnings/errors.

"problemMatcher": [
				{
					"base": "$ada",
					"severity": "info",
					"pattern": {
						"regexp": "^([^:]:?[^:]*):(\\d+):(\\d+):\\s+(\\(style\\)\\s+)(.*)$",
						"file": 1,
						"line": 2,
						"column": 3,
						"message": 5
					}
				},
				{
					"base": "$ada",
					"severity": "warning",
					"pattern": {
						"regexp": "^([^:]:?[^:]*):(\\d+):(\\d+):\\s+(warning)(?:[:]\\s+)?(.*)$",
						"file": 1,
						"line": 2,
						"column": 3,
						"message": 5
					}
				},
				{
					"base": "$ada",
					"severity": "error",
					"pattern": {
						"regexp": "^([^:]:?[^:]*):(\\d+):(\\d+):\\s+?(.*)$",
						"file": 1,
						"line": 2,
						"column": 3,
						"message": 4
					}
				}
			],

[setton]

Hi @patricknoffke, thank you for the heads-up, we'll try to include this soon.

[brownts]

This is an issue for "info" messages also being incorrectly categorized as errors. Hopefully that can be addressed by this update as well.

[mgrojo]

The correct classification for style messages is warning. See https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gnat_ugn_unw/Warning-Message-Control.html

The list is intended to give a general idea of the kinds of warnings that are generated.

• [...]
• Violations of style rules if style checking is enabled

In fact, it is a source of confusion that GNAT is not adding the warning: pattern to these messages. If object code is generated, it cannot be an error.

This lack of correct classification reduces the productivity of the programmer, when we aren't interested on getting things good styled, but trying things out before consolidation.

Maybe this isn't getting the attention it deserves, given that it seems an easy change.

[eliericha]

Hello @mgrojo ,

Thank you for providing more info on this. We will try to tackle this issue soon.

[eliericha]

Hello folks,

This issue has been fixed by defining multiple problem matchers, one of each level of messages: info/warning/error. The fix will be part of the next release.