Creates a new flagset to avoid conflit with other libraries that use the same flag #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the same flag
DataDog/dd-trace-go#1153
❓ What
Baker library conflicts with dd-trace-go library because of dependencies on glog.
glog also defines the flag v
panic: /var/folders/yg/7bk34drs0zjfsb9b_r_1sykr0000gn/T/go-build2940344100/b001/exe/main flag redefined: v
This PR make possible to use both libraries side by side.
It's not possible to send PR to glog because it's a Google internal library that does not accept contributions. But dd-trace-go and also ristretto have dependencies on it.
🔨 How to reproduce the error
Try to import both libraries at the same time:
produces the error:
✅ Checklists
make gofmt-write
been run on the code?make govet
been run on the code? Has the code been fixed accordingly to the output?