Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer Diffusion integration #1150

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

paprik
Copy link

@paprik paprik commented Sep 5, 2024

Basic implementation of ComfyUI Layer Diffusion: https://github.com/huchenlei/ComfyUI-layerdiffuse
Uses two new custom nodes and adds a new transparency checkbox for the Generate action.

Showcase:
transparency_test

@paprik
Copy link
Author

paprik commented Sep 5, 2024

Created as draft since I likely missed something. Generate (with upscaling too) works great. Could not manage to make it work with Refine/Inpaint yet, it keeps adding a white background for some reason.

@Acly
Copy link
Owner

Acly commented Sep 6, 2024

For Refine/Inpaint a special VAE encode is needed that understands transparency. The regular VAE only does RGB (ignores alpha channel).

It was added in forge a while ago, but is not implemented in the ComfyUI nodes.

How can the 2-pass generation (with upscale step) work though? It should run into the same problem?

@paprik
Copy link
Author

paprik commented Sep 6, 2024

You're right, 2-pass upscale doesn't work, I've just generated a 2k in one step. Hopefully it gets added to ComfyUI nodes soon.

I still have to try Attention injection, because the Conv one changes the model a quite a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants