Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Requests] Prompting & Generation Live Preview & HuggingFace Remote VAE Decode & Skip CFG/Negative Prompt & Laplace Scheduler #1628

Closed
vidiotgameboss opened this issue Feb 23, 2025 · 3 comments

Comments

@vidiotgameboss
Copy link

vidiotgameboss commented Feb 23, 2025

Prompting:
Default ComfyUI and by extension this plugin suffers from worse prompting than for example SD.NEXT which has two options that severely increase output quality and ease of prompting: Use line break to segment prompt (equivalent to writing BREAK in a1111) and Force zero tensor on empty prompts (removes any residual noise if for example you got an empty negative prompt)
I believe this could be fixed by updating the currently existing workflows to incorporate the equivalent ComfyUI nodes.
NegPiP and having a token counter per segment would also be incredibly useful when combined with the above.

Generation Live Preview & HuggingFace Remote VAE:
The live previews could use TAESD and the final VAE decode step could use HuggingFace's free remote VAE decodes with a fallback to normal VAE decode when the remote is unavailable.

Skip CFG/Negative Prompt:
This would speed up generation times and produce better results on models that might be a tad bit too creative such as default NoobAI XL VPred 1.0.

Laplace Scheduler:
A scheduler which went under the radar for a majority of time, currently present in reForge. It has been providing me with the best results on VPred/ZTSNR models, as an example it made NoobAI useable with UniPC.

@Acly
Copy link
Owner

Acly commented Mar 11, 2025

Force zero tensor on empty prompts: this gives bad images in combination with IP-adapter in tests:

Image

not entirely sure why, but don't have time to investigate. Don't see a big advantage of zeroing conditioning, unless you just use empty prompt and nothing else. But that's not very useful outside of experiments.

@Acly
Copy link
Owner

Acly commented Mar 11, 2025

Skip CFG/Negative Prompt: this already works, just set CFG to 1

Laplace Scheduler: added for next version

Generation Live Preview & HuggingFace Remote VAE: not planning to do those

@Acly
Copy link
Owner

Acly commented Mar 16, 2025

Zero conditioning just needs to be disabled for SD1.5 apparently.

It is part of 1.32.0. Laplace too.

@Acly Acly closed this as completed Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants