Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷‍♂️ Let's move to Typescript #42

Merged
merged 156 commits into from
Apr 29, 2019
Merged

👷‍♂️ Let's move to Typescript #42

merged 156 commits into from
Apr 29, 2019

Conversation

rimiti
Copy link
Collaborator

@rimiti rimiti commented Apr 6, 2019 •
edited
Loading

Hello,

The purpose of this pull request is to totally rewriting the package with his stores in Typescript to improve his power. 🤓

✅ Check list :

  • ACL core rewrited.
  • Callbacks removed for Promises.
  • Store interface created.
  • Test more strict.
  • CI updated for using current Node LTS.
  • Tslint compliant.
  • Memory store rewrited.
  • Redis store rewrited.
  • MongoDB store rewrited.
  • Express middleware rewrited.
  • Documentation updated.

ℹ️ Note :

  • This version doesn't provide a Sequelize adapter but it should be. If you want to rewrite it, I'll be really happy to merge your pull request. 🙏

rimiti added 30 commits March 19, 2019 11:37
@rimiti
feat(.travis.yml) pipeline updated
d1a42d8
@rimiti
feat(classes/acl.ts) class created
8e5cf84
@rimiti
feat(classes/common.ts) wip
e13396d
@rimiti
feat(classes/acl.ts) constructor + allow method rewrite
c7ce2c0
@rimiti
feat(__tests__/tests.ts) wip
81dc628
@rimiti
feat(__tests__/tests.js) file removed
0305ec8
@rimiti
feat(classes/acl.ts) file created
0eb1210
@rimiti
feat(classes/common.ts) file created
bcee708
@rimiti
feat(interfaces/IAcl.ts) file created
4bba48f
@rimiti
feat(interfaces/IStore.ts) file created
d79526b
@rimiti
feat(stores/memory.ts) file created
effa906
@rimiti
feat(index.ts) file created
c3450c6
@rimiti
chore(.editorconfig) configuration updated
093adee
@rimiti
chore(.gitignore) updated
60d2dd7
@rimiti
chore(.npmignore) updated
6891c84
@rimiti
chore(.prettierrc) file created
f23823f
@rimiti
feat(jest.config.js) file created
8fe2e06
@rimiti
chore(package.json) file updated
2d06e88
@rimiti
feat(tsconfig.json) file created
a8ba9cb
@rimiti
feat(tsconfig.release.json) file created
dfc12fb
@rimiti
feat(tslint.json) file created
fee4b08
@rimiti
feat(yarn.lock) file tracked
94654e2
@rimiti
chore(global) older files removed
8135895
@rimiti
feat(classes/acl.ts) wip
c88796c
@rimiti
feat(interfaces/IAcl.ts) wip
7ff1015
@rimiti
chore(__tests__/tests.ts) tests rewrite
8880730
@rimiti
chore(__tests__/tests.ts) wip
e3f9bdf
@rimiti
feat(classes/common.ts) wip
563307b
@rimiti
feat(stores/memory.ts) wip
bf45c6a
@rimiti
feat(interfaces/IStore.ts) wip
97849aa
rimiti added 26 commits April 27, 2019 19:55
@rimiti
chore(docker-compose-test.yml) mysql container removed
d0a3443
@rimiti
feat(index.ts) sequelize removed
4caa2fe
@rimiti
feat(package.json) dependencies updated
9fe9726
@rimiti
chore(__tests__/tests.ts) connections closed from client
6d17074
@rimiti
feat(stores/sequelize.ts) store removed
1c2b019
@rimiti
chore(__tests__/tests.ts) tests uncommented
0e52f67
@rimiti
doc(README.md) documentation updated
f49c50e
@rimiti
feat(package.json) packages updated + redis and mongodb are now peer …
0ed5339 
…dependencies
@rimiti
chore(yarn.lock) file updated
ef46024
@rimiti
chore(package.json) node-mocks-http removed
f9c9a59
@rimiti
chore(__tests__/tests.ts) tslint compliant
683c7e1
@rimiti
refact(stores/mongodb.ts) typing and lint changes
91c6454
@rimiti
feat(stores/redis.ts) promisified redis check added
325ab95
@rimiti
feat(interfaces/IStore.ts) close method removed
555c18c
@rimiti
Merge remote-tracking branch 'origin/master' into hard-refactoring
99c7d58 
# Conflicts:
#	Dockerfile
#	__tests__/tests.js
#	docker-compose.yml
#	package-lock.json
#	package.json
#	src/stores/sequelize.js
@rimiti
doc(classes/acl.ts) methods documented
547e72e
@rimiti
feat(errors/NotAuthenticated.ts) class created
928f4f0
@rimiti
feat(errors/Forbidden.ts) class created
5b8eb71
@rimiti
feat(classes/httpError.ts) class created
325a6fa
@rimiti
feat(classes/errorHandler.ts) errorHandler function created
1f316b6
@rimiti
chore(__tests__/tests.ts) middleware function tested
e7fe14a
@rimiti
feat(classes/acl.ts) express middleware implemented
db09572
@rimiti
refact(classes/httpError.ts) small refactoring to render props public
fc36c43
@rimiti
feat(errors) folder removed
99621c6
@rimiti
chore(package.json) types packages updated
1612375
@rimiti
feat(index.ts) errorHandler exported
e9fa0cf
@rimiti rimiti merged commit d6aa929 into master Apr 29, 2019
@rimiti rimiti deleted the hard-refactoring branch April 29, 2019 14:24
@rimiti rimiti modified the milestones: v2.0.0-alpha.1, v2.0.0-0 Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rimiti rimiti

Labels
bug enhancement
Projects
None yet
Milestone
v2.0.0-0
Development

Successfully merging this pull request may close these issues.
2 participants
@rimiti @codecov-io