Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher extensions #117

Merged
merged 6 commits into from
Mar 31, 2022
Merged

Publisher extensions #117

merged 6 commits into from
Mar 31, 2022

Conversation

vendulasvastal
Copy link
Contributor

@vendulasvastal vendulasvastal commented Mar 18, 2022 •
edited
Loading

Checklist

  • Added tests (if applicable)

I had to create a new PR because new commits were not showing in the original PR, probably due to some Github issues.

@vendulasvastal vendulasvastal requested a review from olejnjak March 18, 2022 10:24
LukasHromadnik
LukasHromadnik requested changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@LukasHromadnik LukasHromadnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the trailing whitespaces. Otherwise it looks good to me 👍

LukasHromadnik
LukasHromadnik approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@LukasHromadnik LukasHromadnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@olejnjak olejnjak merged commit 1bb67ae into master Mar 31, 2022
@olejnjak olejnjak deleted the publisher-extensions branch March 31, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHromadnik LukasHromadnik LukasHromadnik approved these changes

@olejnjak olejnjak olejnjak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vendulasvastal @LukasHromadnik @olejnjak