🧑💻 UX for Init command + remove unnecessary code #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor so we do not have to find root everytime
lukacan
force-pushed
the
UX/improve-init-experience
branch
from
bfbbada
to
5d9753b
Compare
|
Is it a problem, that you can reinitialize the project? What if the initialization is interrupted (for any reason) and was incomplete (but Trdelnik.toml was created)? It would make sense to run it again no? |
|
Or another case - someone was using old Trdelnik versions and would like to use the fuzzer now. It would be nice to have the option to reinitialize the framework to add the latest changes... |
|
Resolved in #129 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is possible to call trdelnik init while trdelnik is already initialized within the project directory. This PR checks if int the root directory Trdelnik.toml already exists, if so initialization is halted.
Also, this PR removes unnecessary root discovery -> TestGenerator is initialized with the already discovered root