Skip to content

fix(substrate): reword nonexistent-doc xref → proposed location, not current reference#46

Merged
AceHack merged 2 commits intomainfrom
acehack/fix-nonexistent-typescript-conventions-xref
Apr 27, 2026
Merged

fix(substrate): reword nonexistent-doc xref → proposed location, not current reference#46
AceHack merged 2 commits intomainfrom
acehack/fix-nonexistent-typescript-conventions-xref

Conversation

@AceHack
Copy link
Copy Markdown
Owner

@AceHack AceHack commented Apr 27, 2026

Summary

Reword memory/project_install_script_language_strategy_*.md to make explicit that docs/research/post-install-typescript-conventions.md is a proposed future location, not a current reference.

Why

Copilot P1 finding on the LFG sibling PR (Lucent-Financial-Group#643) flagged the ambiguous "capture the conventions in or similar" wording — readers parse this as if the doc were a real artifact. The path doesn't exist.

Same fix already landed on the LFG sibling branch; this PR keeps the AceHack homebase-first invariant so the AceHack→LFG sync produces 0-diff.

Test plan

  • CI green (gate.yml only — substrate-text only)
  • No behavioural change

🤖 Generated with Claude Code

…tall-typescript-conventions.md` is a proposed location, not a current reference

Copilot P1 finding on the LFG sibling PR (Lucent-Financial-Group#643)
flagged that the install-script language-strategy memory file referenced
`docs/research/post-install-typescript-conventions.md` ambiguously
("capture the conventions in <path> or similar"). The path doesn't
exist; readers (Copilot included) parse this as if the doc were a real
artifact.

Reword to make it explicit that this is a proposed future location,
not a current reference. Same fix already landed on the LFG sibling
branch; this PR keeps the AceHack homebase-first invariant.

No behavioural change. Substrate-text only.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 27, 2026 15:59
@AceHack AceHack enabled auto-merge (squash) April 27, 2026 15:59
…integrity hook)

The memory-index-integrity check on AceHack #46 flagged the missing
paired MEMORY.md edit when the install-strategy memory file was
modified. Add a one-line note to the index entry recording the
2026-04-27 wording fix per Copilot LFG Lucent-Financial-Group#643 P1.

Hook satisfied; auto-merge will retry.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clarifies wording in a session memory so readers don’t mistake a nonexistent docs/research/... path for a current in-repo document, instead framing it as a proposed future location.

Changes:

  • Reworded an ambiguous xref to explicitly mark docs/research/post-install-typescript-conventions.md as a future/proposed doc path (not currently present).

@AceHack AceHack merged commit 99e882b into main Apr 27, 2026
16 checks passed
@AceHack AceHack deleted the acehack/fix-nonexistent-typescript-conventions-xref branch April 27, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants