forked from Lucent-Financial-Group/Zeta
-
Notifications
You must be signed in to change notification settings - Fork 0
memory: CodeQL umbrella NEUTRAL detection pattern + org-level inheritance hypothesis (Aaron 2026-04-28) #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AceHack
merged 1 commit into
main
from
memory/codeql-umbrella-neutral-vs-per-language-detection-aaron-2026-04-28
Apr 28, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
...k_codeql_umbrella_neutral_vs_per_language_detection_pattern_aaron_2026_04_28.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,87 @@ | ||||||
| --- | ||||||
| name: CodeQL umbrella check NEUTRAL while per-language Analyze legs SUCCESS — detection pattern for code_quality ruleset BLOCKED state (Aaron 2026-04-28) | ||||||
| description: When `code_quality:severity=all` ruleset gates a PR with "Code quality results are pending for N analyzed languages" and CI looks all-green, the actual signal is the umbrella `CodeQL` check NEUTRAL (often "1 configuration not found" details), distinct from per-language `Analyze (X)` legs that are SUCCESS. Default-setup state alone doesn't predict it. Spotted by Aaron 2026-04-28 on LFG #661; he's seen the pattern in other projects. | ||||||
| type: feedback | ||||||
| --- | ||||||
|
|
||||||
| # CodeQL umbrella NEUTRAL detection pattern (Aaron 2026-04-28) | ||||||
|
|
||||||
| ## The pattern | ||||||
|
|
||||||
| PR is BLOCKED. All visible CI checks are SUCCESS. Merge probe via REST returns: | ||||||
|
|
||||||
| > "Repository rule violations found. Code quality results are pending for N analyzed languages." | ||||||
|
|
||||||
| Diagnostic intuition says CodeQL is failing. But every per-language `Analyze (csharp)`, `Analyze (python)`, `Analyze (javascript-typescript)`, `Analyze (actions)` leg is SUCCESS. CodeQL workflow run completed SUCCESS. SARIF analyses are uploaded for `refs/pull/N/merge` with `results_count: 0` for every language. | ||||||
|
|
||||||
| **The actual signal**: there's a separate `CodeQL` umbrella status check (distinct from the per-language legs) and it's `NEUTRAL` with details URL showing **"1 configuration not found"**. | ||||||
|
|
||||||
| The `code_quality:severity=all` ruleset rule reads the **umbrella** check, not the per-language legs. NEUTRAL → ruleset says "pending." | ||||||
|
|
||||||
| ## Detection in <30 seconds | ||||||
|
|
||||||
| ```bash | ||||||
| # Pull the umbrella CodeQL check specifically: | ||||||
| gh pr view N --repo OWNER/REPO --json statusCheckRollup --jq \ | ||||||
| '.statusCheckRollup[] | select(.name == "CodeQL") | {name, conclusion, detailsUrl}' | ||||||
|
|
||||||
| # If conclusion is NEUTRAL (not SUCCESS) on a PR that's BLOCKED with | ||||||
| # "Code quality results pending" — this is the failure mode. | ||||||
| ``` | ||||||
|
|
||||||
| The umbrella `CodeQL` check is named just `CodeQL` (no language suffix). Don't confuse it with `Analyze (csharp)` etc. | ||||||
|
|
||||||
| ## Empirical evidence collected on LFG #661 (2026-04-28T14:16Z) | ||||||
|
|
||||||
| - Per-language Analyze legs: 4/4 SUCCESS, all `results_count: 0` | ||||||
| - CodeQL workflow runs: SUCCESS | ||||||
| - SARIF analyses uploaded to `refs/pull/661/merge`: 4 entries, all 4 languages | ||||||
| - `CodeQL` umbrella check: **NEUTRAL** with "Completed in 3s — 1 configuration not found" | ||||||
| - LFG default-setup state: `not-configured` | ||||||
| - AceHack default-setup state: `not-configured` (SAME) | ||||||
| - AceHack PR #92 (recent merge): `CodeQL` umbrella = **SUCCESS** despite same default-setup state | ||||||
|
|
||||||
| **Default-setup state alone does NOT predict umbrella outcome.** Something else differs between AceHack and LFG that causes the umbrella to go NEUTRAL on LFG. | ||||||
|
|
||||||
| ## Industry-wide pattern (Aaron 2026-04-28) | ||||||
|
|
||||||
| Aaron's exact framing: "i've seen these before" — across other projects he uses | ||||||
| Claude PR review on. Not a Zeta-specific config bug. The asymmetry between umbrella | ||||||
| NEUTRAL and per-language SUCCESS is a recurring GitHub Code Scanning surface | ||||||
| oddity. | ||||||
|
|
||||||
| ## Why this is hard to see | ||||||
|
|
||||||
| 1. The standard `gh pr checks N` output lists per-language Analyze legs but the | ||||||
| umbrella `CodeQL` check is in a different position visually. | ||||||
| 2. Per-language SUCCESS + workflow SUCCESS gives a strong "everything passed" signal | ||||||
| that masks the umbrella NEUTRAL. | ||||||
| 3. The merge-endpoint error message says "results pending for N analyzed languages" | ||||||
| which sounds like per-language pending, but actually means the umbrella. | ||||||
|
|
||||||
| ## Composes with | ||||||
|
|
||||||
| - `feedback_no_required_approval_on_zeta_BLOCKED_means_threads_or_ci_aaron_2026_04_28.md` | ||||||
| — the 5-class BLOCKED taxonomy. This adds a 6th sub-class: | ||||||
|
||||||
| — the 5-class BLOCKED taxonomy. This adds a 6th sub-class: | |
| — the 5-class BLOCKED taxonomy. This adds a subclass under class 5: |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar: “Aaron seen across other projects” is missing a verb/object and reads ungrammatical. Consider rewriting to “Aaron has seen this across other projects.”