Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use raw-window-handle 0.6 #310

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix: Use raw-window-handle 0.6 #310

merged 1 commit into from
Nov 4, 2023

Conversation

mwcampbell
Copy link
Contributor

Following up on an earlier comment, I don't think it would be right for us to do a new release that depends on an old version of raw-window-handle, if we can easily avoid it. So this PR switches accesskit_winit to use rwh_06. @Vrixyz I believe this can coexist with your code that requires rwh_05, since it seems that those winit features don't actually conflict, but please check.

Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is OK for me indeed!

Mxing raw-window-handle versions seem to never be an option from the GitHub issues I checked on various projects. Therefore I would prefer more input from users before merging.

@Vrixyz
Copy link
Contributor

Vrixyz commented Nov 4, 2023

Yes, I believe your understanding is correct, 2 different versions of rwh should be able to coexist. I'm not sure how to convert from 1 version to the other, I'd guess the pointers are compatible but might require some shenanigans 🤔.

For the record, I initially didn't update to rwh_06 because wgpu wasn't supporting it either, so it gave me enough incentive to not update.

by next bevy version (0.13 ; I guess ~march 2024), we'll probably have an updated wgpu version and no blockers to support only rwh_06, I don't think I'll champion those changes, but that should ease the integration if accesskit upgrades to rwh_06.

@mwcampbell
Copy link
Contributor Author

Since winit itself has rwh_06 as a default feature now, I think it's better for us to use that version. Going to merge.

@mwcampbell mwcampbell merged commit 3fa69ab into main Nov 4, 2023
5 checks passed
@mwcampbell mwcampbell deleted the winit-rwh-06 branch November 4, 2023 20:02
@mwcampbell mwcampbell mentioned this pull request Nov 4, 2023
@Vrixyz
Copy link
Contributor

Vrixyz commented Dec 13, 2023

Hey, with bevy winit/accesskit update, I realized having multiple version is not pleasing our CI (we're trying to avoid duplicate dependencies). Would you be against having a feature rwh_05 ?

Pretty much reverting your changes behind a feature flag akin to how winit do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants