-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update winit to 0.28 #207
Update winit to 0.28 #207
Conversation
Please revert the Cargo.lock removal, and commit the updated Cargo.lock for this winit update. I was aware of the guideline when I made the decision to commit Cargo.lock, and I did it anyway. My rationale was that I figured I might eventually include official language bindings in this monorepo, and those will be cdylib and/or staticlib projects. I don't know if we'll still include those eventual bindings in this repo, but I'd rather evaluate that separately. |
Sure, no problem! |
The reason I listed winit again under dev-dependencies was so our example could run with all default features, including Wayland client-side decorations where necessary. Disabling that feature in the base dependency on winit is no longer as necessary, now that winit doesn't depend on crossfont by default, but I'd rather keep it that way. |
Well, serves me right for thinking I know better :) |
No worries. You are a more experienced Rust dev than I am. Guess I should have added a comment there. |
OK, accesskit_winit v0.9.0 is published. I realize this is necessary to unblock the update to winit 0.28 in egui. |
Thanks for the quick response! 🙏 |
I also removed
Cargo.lock
from git, since this is a library (see https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html). Let me know if I went to far here!