Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit to 0.28 #207

Merged
merged 6 commits into from
Feb 2, 2023
Merged

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Feb 2, 2023

I also removed Cargo.lock from git, since this is a library (see https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html). Let me know if I went to far here!

@mwcampbell
Copy link
Contributor

Please revert the Cargo.lock removal, and commit the updated Cargo.lock for this winit update. I was aware of the guideline when I made the decision to commit Cargo.lock, and I did it anyway. My rationale was that I figured I might eventually include official language bindings in this monorepo, and those will be cdylib and/or staticlib projects. I don't know if we'll still include those eventual bindings in this repo, but I'd rather evaluate that separately.

@emilk
Copy link
Contributor Author

emilk commented Feb 2, 2023

Sure, no problem!

platforms/winit/Cargo.toml Outdated Show resolved Hide resolved
@mwcampbell
Copy link
Contributor

The reason I listed winit again under dev-dependencies was so our example could run with all default features, including Wayland client-side decorations where necessary. Disabling that feature in the base dependency on winit is no longer as necessary, now that winit doesn't depend on crossfont by default, but I'd rather keep it that way.

@emilk
Copy link
Contributor Author

emilk commented Feb 2, 2023

Well, serves me right for thinking I know better :)

@mwcampbell
Copy link
Contributor

No worries. You are a more experienced Rust dev than I am. Guess I should have added a comment there.

@mwcampbell mwcampbell merged commit 3ff0cf5 into AccessKit:main Feb 2, 2023
@github-actions github-actions bot mentioned this pull request Feb 2, 2023
@mwcampbell
Copy link
Contributor

OK, accesskit_winit v0.9.0 is published. I realize this is necessary to unblock the update to winit 0.28 in egui.

@emilk
Copy link
Contributor Author

emilk commented Feb 2, 2023

Thanks for the quick response! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants