-
Notifications
You must be signed in to change notification settings - Fork 573
Conversation
LGTM from my side, @RobertNorthard can you test/review please? |
Hi @marisbahtins / @dsingh07 I reviewed on a fresh stack and I am unable to login. The following exception is in the log:
Maybe all the dependencies should be backed into the image. Also, some environments do not have outbound internet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug as per comments.
This is now fixed by @marisbahtins in Accenture/adop-nexus#14 by pre-downloading all the dependencies. Have cut a new release with that PR merged in: https://github.com/Accenture/adop-nexus/releases/tag/0.2.2
|
Thanks @dsingh07 and thank you @marisbahtins Test cases performed:
The only defect is that the Nexus sign-out link does not log the currently authenticated principle out. This is because the proxy will log you back in as Basic authentication is off-loaded to the proxy. |
Added required parameters for new Nexus image.