Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

HTTP GET request to get load_cartridge job to load defaults params. #198

Merged
merged 1 commit into from
Mar 13, 2017
Merged

HTTP GET request to get load_cartridge job to load defaults params. #198

merged 1 commit into from
Mar 13, 2017

Conversation

RobertNorthard
Copy link
Contributor

@RobertNorthard RobertNorthard commented Mar 10, 2017

The SCM provider parameter is an empty string when the Load_Cartridge job is invoked from a Load_Cartridge_Collection when using the ADOP CLI prior to load cartridge being built through the UI.

This is beacuse;

  • the SCM provider default choice list has not been populated
  • build parameters that are generated by Scriptler/Groovy scripts are only populated when the Load_Cartridge job "buildWithParameters" has been clicked.

To resolve this prior to running Load_Cartridge a HTTP GET request can be executed to ensure the default parameters are loaded.

To confirm this change behaves as expected check out this PR and run the following CLI commands against a target ADOP. Compare the results with the CLI prior to this PR.

./adop workspace -w DOA create; sleep 10
./adop project -p Labs -w DOA create; sleep 10
./adop project -p Labs -w DOA load_collection -c https://raw.githubusercontent.com/Accenture/adop-doa-materials/master/Cartridge_Collections/doa_cartridge_collection.json

Copy link
Contributor

@dsingh07 dsingh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @RobertNorthard

I've tested the above 3 CLI commands and it works fine under all default scenarios.

The cartridge collection is succesfully populates in the project.

@RobertNorthard RobertNorthard changed the title HTTP GET request to load_cartridge job to load defaults params. HTTP GET request to get load_cartridge job to load defaults params. Mar 10, 2017
@dsingh07 dsingh07 merged commit 44bd3b0 into Accenture:master Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants