handle nonce for eth tx

[ermalkaleci]

closes #1702

[zjb0807]

Please merge master. AcalaMultiSignature::Eip1559 was added.

[xlc]

I am not sure if this can handle recursive calls. i.e. when an evm call somehow triggers a dispatch of another evm call. this is not yet possible but could be in future.

[ermalkaleci]

I am not sure if this can handle recursive calls. i.e. when an evm call somehow triggers a dispatch of another evm call. this is not yet possible but could be in future.

@xlc maybe we can do take so skip_nonce_incremental is read once

[xlc]

A DispatchError should still not resulting any state change. This means you will want to make it success even if the evm execution failed and emit another event to indicate the error

[zjb0807]

@ermalkaleci I think doing it in post_dispatch is better. Avoid modifying the EVM.

[ermalkaleci]

@ermalkaleci I think doing it in post_dispatch is better. Avoid modifying the EVM.

@zjb0807 nonce is incremented before call and after create

[zjb0807]

@zjb0807 nonce is incremented before call and after create

But I think the #[transactional] is more important. The nonce will be increased in the evm module. If the tx returns an error without inc_nonce in evm, the nonce will be increased in post_dispatch.

[zjb0807]

Acala/modules/evm/src/runner/stack.rs

Lines 226 to 229 in b8e0d02

	ensure!(
	Pallet::<T>::can_call_contract(&target, &source),
	Error::<T>::NoPermission
	);

Such as this error, we also need to increase nonce.

[zjb0807]

Acala/modules/evm/src/runner/state.rs

Line 384 in b8e0d02

self.state.inc_nonce(caller);

Acala/modules/evm/src/runner/state.rs

Line 577 in b8e0d02

self.state.inc_nonce(caller);

Or remove these inc_nonce in evm module, increase the evm nonce like frame_system::Account nonce in pre_dispatch.

[zjb0807]

https://github.com/ethereum/go-ethereum/blob/12f971fb2d/core/state_transition.go#L321

It seems that there is no need to guarantee that the nonce must be increased. In ethereum, there are some checks before increasing nonce.

[codecov]

Codecov Report

Merging #1707 (f9f861e) into master (6c7f819) will increase coverage by 6.16%.
The diff coverage is 77.42%.

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
+ Coverage   66.91%   73.08%   +6.16%     
==========================================
  Files         224      173      -51     
  Lines       19764    19182     -582     
==========================================
+ Hits        13226    14020     +794     
+ Misses       6538     5162    -1376     

Impacted Files	Coverage Δ
ecosystem-modules/compound-cash/src/lib.rs	0.00% <0.00%> (-7.15%)	⬇️
inspect/src/lib.rs	0.00% <ø> (-35.78%)	⬇️
modules/evm-utiltity/macro/src/lib.rs	0.00% <0.00%> (ø)
modules/evm/src/runner/state.rs	53.57% <ø> (ø)
modules/evm/src/runner/storage_meter.rs	97.08% <ø> (+8.99%)	⬆️
modules/evm/src/tests.rs	99.14% <ø> (+0.46%)	⬆️
modules/example/src/lib.rs	74.19% <ø> (-5.12%)	⬇️
modules/example/src/tests.rs	100.00% <ø> (ø)
modules/homa-lite/src/lib.rs	89.73% <ø> (-2.43%)	⬇️
modules/homa-lite/src/mock_no_fees.rs	67.92% <ø> (ø)
... and 284 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486d5bc...f9f861e. Read the comment docs.