-
Notifications
You must be signed in to change notification settings - Fork 721
Idle schedule evm task #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idle schedule evm task #1583
Conversation
xlc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now delete contract is not atomic action. is it possible to create a contract with same address of a deleting one? I think that's possible and we need to make sure that action will fail, instead of overriding storages.
|
we need to make sure it's not possible to deploy at the same address until everything is wiped out |
Acala/modules/evm/src/runner/state.rs Lines 580 to 583 in ba2e0ce
I checked the Line 1584 in ba2e0ce
I'll add a test case. |
|
In order to avoid adding extra |
Closes: #612 #1459