Disable xcm method #1558
Merged
Disable xcm method #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunxw
reviewed
Oct 29, 2021
Member
|
best to do a exhaustive match listing all the calls so in future if new calls are introduced, it will be a compiling error |
Contributor
Author
|
As the Call enum has __Ignore case, so here the default case we return unimplemented!() Modified: use the __Ignore instead of _, this can ensure that if there're method changes in pallet-xcm, then we should change this BaseFilter, or-else it'll have compiling error. |
xlc
reviewed
Nov 1, 2021
xlc
approved these changes
Nov 1, 2021
Contributor
Author
|
@zjb0807 would you look at the failed e2e-tests? |
Contributor
Retry it works. |
syan095
pushed a commit
that referenced
this pull request
Nov 3, 2021
…eriodic-update * origin/master: Feature/add update available staking (#1514) Clean Dependencies (#1577) Disable xcm method (#1558) # Conflicts: # modules/homa-lite/src/benchmarking.rs # modules/homa-lite/src/lib.rs # modules/homa-lite/src/tests.rs # modules/homa-lite/src/weights.rs # runtime/acala/src/weights/module_homa_lite.rs # runtime/karura/src/weights/module_homa_lite.rs # runtime/mandala/src/weights/module_homa_lite.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #1557