Changed the way base withdraw fee is charged #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2021 17:42
Updated unit tests for module-homa-lite
xlc
reviewed
Oct 21, 2021
Fixed a mis-formatted comment
xlc
reviewed
Oct 22, 2021
xlc
approved these changes
Oct 22, 2021
xlc
pushed a commit
that referenced
this pull request
Oct 25, 2021
* WIP: Improved the way base withdraw fee is charged for redeemers Updated unit tests for module-homa-lite * Updated the integration tests for the new way the withdraw fee is charged * Addressed some PR comments. Fixed a mis-formatted comment * Addressed a PR comment Co-authored-by: Roy Yang <roy@laminar.one>
syan095
pushed a commit
that referenced
this pull request
Oct 27, 2021
…available-staking * origin/master: support BNC as fee token (#1528) Remove dex trading path check in predeploy-contracts (#1529) bump spec version update orml (#1533) use PolkadotXcm for wrap version (#1530) set xcm version to 2 upon upgrade (#1515) test on release branch increase trading path limit (#1522) bump spec version move tests to individual files (#1518) bump version (#1516) Changed the way base withdraw fee is charged (#1512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base withdraw fee is changed for all redeem request, and is slashed (burned) on redeem.
Updated unit tests and integration tests
Closes #1508