-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1263 new dev paths options #1270
base: main
Are you sure you want to change the base?
Issue 1263 new dev paths options #1270
Conversation
Let's say we have a package `helloworld` in D:\dev\helloworld(a pure python package, and no version specified) want to test, but don't want to move it to any package repository or package filters, instead call this package like this: `rez-env helloworld pkg1 pkg2 ... -d D:\dev`, helloworld will be resolved to D:\dev\helloworld, but pkg1 and pkg2 resolved to a repository path in rez config. or if is also in D:\dev folder.
This reverts commit 5f94b9c.
…lized." This reverts commit 87ee4e6.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
But this still can't ensure the resloved packages are always picked from the paths added, for testing purpose, we want to pick the packages from we specifed path instead of the highest best resovled versions. For non version packge, have to do like this or specify a version in that path, otherwise rez will pick the highest version from other repo.
|
As mentioned in the thread, |
As I can see, to solve the problem mentioned in #1263, to allow requiring a package directly from a path
|
The suggested PR change adds 2 new CLI arguments, rez-env blah --add-pre-paths /before --paths /foo --add-post-paths /after Is the same as this: rez-env blah --paths /before:/foo:/after I don't want to speak for Allan so I'll let him weigh in, but it sounds like he wants to implement a stacked package orderer and wrap that into a CLI argument. At present, I don't see this PR providing functionality that we can't already get with As it is, this PR still has the same problems as described in #1263 (comment) |
Yes, this only makes it a bit more user friendly instead of passing all paths by Since |
In the spirit of development by committee (which makes sense wrt the move to aswf) I'm gonna put this one to a vote. Personally I'm tending to not be in favour. As Colin points out you can just use Please cast your vote, I'll check in again in a while. |
I sympathize with the issues pointed out in #1263 so I would like that workflow to be improved, however I don't think this PR fully solves the problem, I'd rather we wait for a package orderer to see if it covers all of our use-cases. e.g. I'm imagining something like
Once we have that functionality in, I suspect this PR won't be needed as the orderer will handle all of our use-cases. My vote is to wait or close this PR and, if the orderer doesn't do what we need, we can always re-open the PR later. |
According to @nerdvegas's suggest, added
add_pre_paths
andadd_post_paths
options to rez-env cli.Related issue:
#1263