Use Larger GHA instances from ASWF for Linux/Windows #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrbailey
requested review from
kmuseth,
apradhana,
jmlait,
Idclip and
richhones
as code owners
danrbailey
force-pushed
the
gha_update_ci
branch
2 times, most recently
from
c13b181 to
a106ceb
Compare
danrbailey
force-pushed
the
gha_update_ci
branch
from
b0cbc46 to
91283d5
Compare
danrbailey
force-pushed
the
gha_update_ci
branch
2 times, most recently
from
614170b to
b29a74e
Compare
danrbailey
commented
Oct 7, 2022
| get_target_property(ILMBASE_LIB_TYPE Imath::Imath TYPE) | ||
| else() | ||
| get_target_property(ILMBASE_LIB_TYPE IlmBase::Half TYPE) | ||
| endif() |
There was a problem hiding this comment.
@Idclip - any thoughts on this particular change? This is the only bit that doesn't touch the switch to 8 core builds.
There was a problem hiding this comment.
lgtm, why did this randomly start failing?
There was a problem hiding this comment.
I don't know precisely, but I think it's most likely the version of imath/half being provided from vcpkg. It's only failing in the Windows builds.
There was a problem hiding this comment.
The change is consistent with what's needed for upgrading to OpenEXR 3.X when they did the Imath separation. And indeed it looks like vcpkg just updated to OpenEXR 3.1 a mere 12 days ago:
There was a problem hiding this comment.
Thanks for confirming!
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
danrbailey
force-pushed
the
gha_update_ci
branch
from
b29a74e to
667c6d7
Compare
Merged
Idclip
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.