Fixed invalid Win32 installation script.#366
Closed
crud89 wants to merge 2 commits intoAcademySoftwareFoundation:masterfrom
Closed
Fixed invalid Win32 installation script.#366crud89 wants to merge 2 commits intoAcademySoftwareFoundation:masterfrom
crud89 wants to merge 2 commits intoAcademySoftwareFoundation:masterfrom
Conversation
Contributor
|
So this whole section can be removed, which should fix any issues you have. |
Author
Thanks for the reply! I've removed the block and rebuilt the project. Everything works as expected. |
Contributor
|
Removed the offending chunk, thanks for the report! |
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 16, 2025
Note that libImath.so is missing from the install manifest because OpenEXR v3.3 links against Imath 3.1, which has a bug where the libImath.so symlink fails to get added to the install manifest, fixed in PR AcademySoftwareFoundation#366. Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 16, 2025
Note that libImath.so is missing from the install manifest because OpenEXR v3.3 links against Imath 3.1, which has a bug where the libImath.so symlink fails to get added to the install manifest, fixed in PR AcademySoftwareFoundation#366. Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 18, 2025
Note that libImath.so is missing from the install manifest because OpenEXR v3.3 links against Imath 3.1, which has a bug where the libImath.so symlink fails to get added to the install manifest, fixed in PR AcademySoftwareFoundation#366. Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 19, 2025
Note that libImath.so is missing from the install manifest because OpenEXR v3.3 links against Imath 3.1, which has a bug where the libImath.so symlink fails to get added to the install manifest, fixed in PR AcademySoftwareFoundation#366. Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Mar 20, 2025
Note that libImath.so is missing from the install manifest because OpenEXR v3.3 links against Imath 3.1, which has a bug where the libImath.so symlink fails to get added to the install manifest, fixed in PR #366. Signed-off-by: Cary Phillips <cary@ilm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue #355 describes a problem with building OpenEXR from CMake under Windows. Currently, the IlmImf project will be copied into
C:/bin/, resulting in an incomplete install.The problem originates from an invalid usage of the
${OPENEXR_PACKAGE_PREFIX}, which is never set by default and also not exposed to the cmake cache. Assuming this was unintented, replacing it with${CMAKE_INSTALL_PREFIX}fixes the issue.The issue only affects Windows builds and the fix should not affect builds for environments different to
WIN32.