Skip to content

Fixed invalid Win32 installation script.#366

Closed
crud89 wants to merge 2 commits intoAcademySoftwareFoundation:masterfrom
crud89:master
Closed

Fixed invalid Win32 installation script.#366
crud89 wants to merge 2 commits intoAcademySoftwareFoundation:masterfrom
crud89:master

Conversation

@crud89
Copy link

@crud89 crud89 commented Dec 17, 2018

The issue #355 describes a problem with building OpenEXR from CMake under Windows. Currently, the IlmImf project will be copied into C:/bin/, resulting in an incomplete install.

The problem originates from an invalid usage of the ${OPENEXR_PACKAGE_PREFIX}, which is never set by default and also not exposed to the cmake cache. Assuming this was unintented, replacing it with ${CMAKE_INSTALL_PREFIX} fixes the issue.

The issue only affects Windows builds and the fix should not affect builds for environments different to WIN32.

@hjmallon
Copy link
Contributor

WORKING_DIR is not used anywhere in the CMake project so should be removed.
RUNTIME_DIR is correctly set in OpenEXRSettings.cmake which is fixed as of 26c8619

So this whole section can be removed, which should fix any issues you have.

@crud89
Copy link
Author

crud89 commented Jan 28, 2019

WORKING_DIR is not used anywhere in the CMake project so should be removed.
RUNTIME_DIR is correctly set in OpenEXRSettings.cmake which is fixed as of 26c8619

So this whole section can be removed, which should fix any issues you have.

Thanks for the reply! I've removed the block and rebuilt the project. Everything works as expected.

@meshula
Copy link
Contributor

meshula commented Mar 30, 2019

Removed the offending chunk, thanks for the report!
737bc29

@meshula meshula closed this Mar 30, 2019
@cary-ilm cary-ilm modified the milestone: v2.4.0 Aug 10, 2019
cary-ilm added a commit to cary-ilm/openexr that referenced this pull request Mar 16, 2025
Note that libImath.so is missing from the install manifest because
OpenEXR v3.3 links against Imath 3.1, which has a bug where the
libImath.so symlink fails to get added to the install manifest, fixed
in PR AcademySoftwareFoundation#366.

Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm added a commit to cary-ilm/openexr that referenced this pull request Mar 16, 2025
Note that libImath.so is missing from the install manifest because
OpenEXR v3.3 links against Imath 3.1, which has a bug where the
libImath.so symlink fails to get added to the install manifest, fixed
in PR AcademySoftwareFoundation#366.

Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm added a commit to cary-ilm/openexr that referenced this pull request Mar 18, 2025
Note that libImath.so is missing from the install manifest because
OpenEXR v3.3 links against Imath 3.1, which has a bug where the
libImath.so symlink fails to get added to the install manifest, fixed
in PR AcademySoftwareFoundation#366.

Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm added a commit to cary-ilm/openexr that referenced this pull request Mar 19, 2025
Note that libImath.so is missing from the install manifest because
OpenEXR v3.3 links against Imath 3.1, which has a bug where the
libImath.so symlink fails to get added to the install manifest, fixed
in PR AcademySoftwareFoundation#366.

Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm added a commit that referenced this pull request Mar 20, 2025
Note that libImath.so is missing from the install manifest because
OpenEXR v3.3 links against Imath 3.1, which has a bug where the
libImath.so symlink fails to get added to the install manifest, fixed
in PR #366.

Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants