Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added default_value fallback to serializable_field property #1658

Merged

Conversation

timlehr
Copy link
Contributor

@timlehr timlehr commented Aug 23, 2023

Link the Issue(s) this Pull Request is related to.

Fixes #1657

Summarize your change.

Simple addition to the code to make sure access to a field that hasn't been initialized yet doesn't fail and returns a fallback default value instead.

@codecov-commenter
Copy link

Codecov Report

Merging #1658 (1b18f60) into main (45c6cfd) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
- Coverage   79.91%   79.90%   -0.01%     
==========================================
  Files         197      197              
  Lines       21731    21731              
  Branches     4339     4339              
==========================================
- Hits        17367    17365       -2     
- Misses       2213     2214       +1     
- Partials     2151     2152       +1     
Flag Coverage Δ
py-unittests 79.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../py-opentimelineio/opentimelineio/core/__init__.py 83.33% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c6cfd...1b18f60. Read the comment docs.

@meshula meshula merged commit 4b3b673 into AcademySoftwareFoundation:main Apr 18, 2024
@timlehr timlehr deleted the field_default_value_timlehr branch April 18, 2024 20:45
darbyjohnston pushed a commit to darbyjohnston/OpenTimelineIO that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default fallback value to serializable field properties in Python
3 participants