Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compiling with GCC 13 #1605

Merged

Conversation

JeanChristopheMorinPerso
Copy link
Member

When compiling with GCC 13, we get errors like this:

In file included from /home/jcmorin/jcmenv/aswf/OpenTimelineIO/src/opentime/rationalTime.cpp:4:
/home/jcmorin/jcmenv/aswf/OpenTimelineIO/src/opentime/rationalTime.h: In function ‘constexpr double opentime::v1_0::fabs(double)’:
/home/jcmorin/jcmenv/aswf/OpenTimelineIO/src/opentime/rationalTime.h:27:9: error: ‘uint64_t’ does not name a type
   27 |         uint64_t i;
      |         ^~~~~~~~
/home/jcmorin/jcmenv/aswf/OpenTimelineIO/src/opentime/rationalTime.h:10:1: note: ‘uint64_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
    9 | #include <limits>
  +++ |+#include <cstdint>
   10 | #include <string>
/home/jcmorin/jcmenv/aswf/OpenTimelineIO/src/opentime/rationalTime.h:29:10: error: ‘union opentime::v1_0::fabs(double)::<unnamed>’ has no member named ‘i’
   29 |     bits.i &= std::numeric_limits<uint64_t>::max() / 2;
      |          ^
/home/jcmorin/jcmenv/aswf/OpenTimelineIO/src/opentime/rationalTime.h:29:35: error: ‘uint64_t’ was not declared in this scope
   29 |     bits.i &= std::numeric_limits<uint64_t>::max() / 2;
      |                                   ^~~~~~~~
/home/jcmorin/jcmenv/aswf/OpenTimelineIO/src/opentime/rationalTime.h:29:35: note: ‘uint64_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
/home/jcmorin/jcmenv/aswf/OpenTimelineIO/src/opentime/rationalTime.h:29:43: error: template argument 1 is invalid
   29 |     bits.i &= std::numeric_limits<uint64_t>::max() / 2;

Like the note says, we need to include cstdint. This is also documented in https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes.

Signed-off-by: Jean-Christophe Morin <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1605 (589f6b7) into main (23ff3f9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1605   +/-   ##
=======================================
  Coverage   79.91%   79.91%           
=======================================
  Files         197      197           
  Lines       21731    21731           
  Branches     4339     4339           
=======================================
  Hits        17366    17366           
  Misses       2213     2213           
  Partials     2152     2152           
Flag Coverage Δ
py-unittests 79.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/opentime/rationalTime.h 94.31% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ff3f9...589f6b7. Read the comment docs.

@meshula meshula merged commit d1e7807 into AcademySoftwareFoundation:main May 20, 2023
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Michele Spina <[email protected]>
apetrynet pushed a commit to apetrynet/OpenTimelineIO that referenced this pull request Aug 7, 2023
Signed-off-by: Jean-Christophe Morin <[email protected]>
(cherry picked from commit d1e7807)
jminor pushed a commit that referenced this pull request Aug 7, 2023
Signed-off-by: Jean-Christophe Morin <[email protected]>
(cherry picked from commit d1e7807)

Co-authored-by: Jean-Christophe Morin <[email protected]>
travier pushed a commit to EliasTheGrandMasterOfMistakes/org.kde.kdenlive that referenced this pull request Dec 20, 2023
jlskuz pushed a commit to flathub/org.kde.kdenlive that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants