Skip to content

Commit

Permalink
Prepare plugin detection for removal of the cmx_3600 adapter (#1488)
Browse files Browse the repository at this point in the history
* add "extract_adapters" to CI triggers
* use "otiod" as override example

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
  • Loading branch information
apetrynet authored and reinecke committed Jun 12, 2024
1 parent 3d46584 commit 5ef5481
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: docs

on:
push:
branches: [ main ]
branches: [ main, extract_adapters ]
pull_request:
branches: [ main ]
branches: [ main, extract_adapters ]

jobs:
check-links:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ env:

on:
push:
branches: [ main ]
branches: [ main, extract_adapters ]
pull_request:
branches: [ main ]
branches: [ main, extract_adapters ]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"adapters": [
{
"OTIO_SCHEMA" : "Adapter.1",
"name" : "cmx_3600",
"name" : "otiod",
"filepath" : "adapter.py",
"suffixes" : ["edl"]
"suffixes" : ["otiod"]
}
]
}
6 changes: 3 additions & 3 deletions tests/test_plugin_detection.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ def test_override_adapter(self):
# Test that entrypoint plugins load before builtin and contrib
man = otio.plugins.manifest.load_manifest()

# The override_adapter creates another cmx_3600 adapter
# The override_adapter creates another otiod adapter
adapters = [adapter for adapter in man.adapters
if adapter.name == "cmx_3600"]
if adapter.name == "otiod"]

# More then one cmx_3600 adapter should exist.
# More then one otiod adapter should exist.
self.assertTrue(len(adapters) > 1)

# Override adapter should be the first adapter found
Expand Down

0 comments on commit 5ef5481

Please sign in to comment.