Sonar warning fixes and improvements #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Minor changes to fix a couple more warnings given by SonarCloud static analysis. * Get the code coverage enabled, it wasn't running properly. * testrender: allow secret TESTRENDER_AA to override command line --aa * runtest.py: allow secret OSL_TESTSUITE_SKIP_DIFF to force skipping the reference comparison step. * For analysis run, set TESTRENDER_AA=1 to keep the tests from being prohibitively expensive, and OSL_TESTSUITE_SKIP_DIFF=1 to keep it from failing because the aa=1 images are different. Signed-off-by: Larry Gritz <[email protected]>
fpsunflower
approved these changes
Aug 28, 2022
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 29, 2022
…ion#1563) * Minor changes to fix a couple more warnings given by SonarCloud static analysis. * Get the code coverage enabled, it wasn't running properly. * testrender: allow secret TESTRENDER_AA to override command line --aa * runtest.py: allow secret OSL_TESTSUITE_SKIP_DIFF to force skipping the reference comparison step. * For analysis run, set TESTRENDER_AA=1 to keep the tests from being prohibitively expensive, and OSL_TESTSUITE_SKIP_DIFF=1 to keep it from failing because the aa=1 images are different. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 29, 2022
…ion#1563) * Minor changes to fix a couple more warnings given by SonarCloud static analysis. * Get the code coverage enabled, it wasn't running properly. * testrender: allow secret TESTRENDER_AA to override command line --aa * runtest.py: allow secret OSL_TESTSUITE_SKIP_DIFF to force skipping the reference comparison step. * For analysis run, set TESTRENDER_AA=1 to keep the tests from being prohibitively expensive, and OSL_TESTSUITE_SKIP_DIFF=1 to keep it from failing because the aa=1 images are different. Signed-off-by: Larry Gritz <[email protected]>
lgritz
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR #1563 accidentally changed tests to accept failing commands by default. (This seems to have been a mistake -- a temporary change added when debugging that LG neglected to remove before submitting the PR.) This can cause tests to pass even though the program crashed, when a previous run created the correct output file. --------- Signed-off-by: Brecht Van Lommel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to fix a couple more warnings given by SonarCloud
static analysis.
Get the code coverage enabled, it wasn't running properly.
testrender: allow secret TESTRENDER_AA to override command line --aa
runtest.py: allow secret OSL_TESTSUITE_SKIP_DIFF to force skipping
the reference comparison step.
For analysis run, set TESTRENDER_AA=1 to keep the tests from being
prohibitively expensive, and OSL_TESTSUITE_SKIP_DIFF=1 to keep it
from failing because the aa=1 images are different.
Signed-off-by: Larry Gritz [email protected]