Add missing cases for MaterilaX closure refraction index detection #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconty
approved these changes
Aug 22, 2022
|
The CI failures on the "bleeding edge" and "clang14" test are both just the render-microfacet issue again (hopefully made more rare by #1558). They can be ignored for the sake of this PR. But the failed "clang-format" test does point out some formatting fixes, you just need to run the touched files through clang-format. |
|
This PR is related to the discussion here: AcademySoftwareFoundation/MaterialX#1039 |
This allows the refraction index to be detected even if a medium closure is not present. Additionally, the medium detection now traverses layer() closures. Signed-off-by: Chris Kulla <[email protected]>
fpsunflower
force-pushed
the
new-mx-ior-logic
branch
from
17e71f5 to
b7209fa
Compare
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 23, 2022
…cademySoftwareFoundation#1557) This allows the refraction index to be detected even if a medium closure is not present. Additionally, the medium detection now traverses layer() closures. Signed-off-by: Chris Kulla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the refraction index to be detected even if a medium closure
is not present. Additionally, the medium detection now traverses layer()
closures.