Switch testrender to cone tracing #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aconty
force-pushed
the
cone-tracing
branch
2 times, most recently
from
3bcae91 to
f195a9c
Compare
fpsunflower
reviewed
Jul 29, 2022
src/testrender/shading.cpp
Outdated
| return Color3(c.x < min ? min : max < c.x ? max : c.x, | ||
| c.y < min ? min : max < c.y ? max : c.y, | ||
| c.z < min ? min : max < c.z ? max : c.z); | ||
| return Color3(c.x < min ? min |
There was a problem hiding this comment.
This line looks like it got formatted a bit strangely?
fpsunflower
approved these changes
Jul 29, 2022
|
Maybe, but that's the project configuration as far as I know. |
aconty
force-pushed
the
cone-tracing
branch
2 times, most recently
from
8d875d3 to
bfc9e6e
Compare
fpsunflower
approved these changes
Jul 31, 2022
The idea is to stop propagating derivs through BSDFs, which we
never did properly. Instead we trace rays with radius + spread,
which we turn into OSL derivs in SG when we hit a surface. Then
when bouncing off a surface we use the BSDF roughness to set the
spread. In addition we also:
* Return BSDF samples/eval as a small struct Sample(). This
avoids output parameters in the methods.
* Stop passing a full ShaderGlobals to the BSDF methods. Pass
a viewing direction wo instead so they could run in a simpler
context.
Signed-off-by: Alejandro Conty <[email protected]>
fpsunflower
approved these changes
Aug 2, 2022
|
No problem! Thanks |
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 4, 2022
The idea is to stop propagating derivs through BSDFs, which we
never did properly. Instead we trace rays with radius + spread,
which we turn into OSL derivs in SG when we hit a surface. Then
when bouncing off a surface we use the BSDF roughness to set the
spread. In addition we also:
* Return BSDF samples/eval as a small struct Sample(). This
avoids output parameters in the methods.
* Stop passing a full ShaderGlobals to the BSDF methods. Pass
a viewing direction wo instead so they could run in a simpler
context.
Signed-off-by: Alejandro Conty <[email protected]>
chellmuth
pushed a commit
to chellmuth/OpenShadingLanguage
that referenced
this pull request
Sep 6, 2024
Relevant changes: * GPU string fix -- needed missing cast (AcademySoftwareFoundation#1553) * Fix typo error that prevented correct typecheck of ternary (AcademySoftwareFoundation#1552) * testrender now supports the standard MaterialX closure: * testrender improvements: modernize sampler (AcademySoftwareFoundation#1534), switch to cone tracing (AcademySoftwareFoundation#1543), support MaterialX closures (AcademySoftwareFoundation#1533, AcademySoftwareFoundation#1536, AcademySoftwareFoundation#1537, AcademySoftwareFoundation#1538, AcademySoftwareFoundation#1541, AcademySoftwareFoundation#1542, AcademySoftwareFoundation#1547) * Bump LLVM to 14.0 * Help reduce PTX nondeterminism (AcademySoftwareFoundation#1570) See merge request spi/dev/3rd-party/osl-feedstock!30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea is to stop propagating derivs through BSDFs, which we
never did properly. Instead we trace rays with radius + spread,
which we turn into OSL derivs in SG when we hit a surface. Then
when bouncing off a surface we use the BSDF roughness to set the
spread. In addition we also:
avoids output parameters in the methods.
a viewing direction wo instead so they could run in a simpler
context.
Tests
Updated testrender tests because of very minimal diffs.
Checklist: