clang-format more of the code base #1508
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring more files into the clang-format fold, primarily things related to batch shading,
which we had held off on reformatting while they were being actively worked on.
Because this is just reformatting and not changing any code, I've attributed the
commits to the individual people who were the predominant authors of the files
in question, to preserve the amount of LOC authorship they get if somebody
runs statistics on the files. I hope that's ok, Alex and Stephen. It's 100% your code as
far as I'm concerned, I'm just preventing this automated process from changing
apparent authorship to me (which I feel would be more dishonest than this extremely
minor way that I am sort of forging a commit in your name.)
In addition to the clang-format reformatting, I've also taken the liberty of making most of
these files conform to our blank space conventions -- three blank lines between freestanding
function implementations, never more than one blank line in a row INSIDE a function,
and no blank lines immediately after an opening brace or immediately before a closing
brace. That is beyond the domain of clang-format, but I think those conventions promote
clear visual parsing (at least by me) of the code layout.