Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format more of the code base #1508

Closed
wants to merge 0 commits into from

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented May 14, 2022

Bring more files into the clang-format fold, primarily things related to batch shading,
which we had held off on reformatting while they were being actively worked on.

Because this is just reformatting and not changing any code, I've attributed the
commits to the individual people who were the predominant authors of the files
in question, to preserve the amount of LOC authorship they get if somebody
runs statistics on the files. I hope that's ok, Alex and Stephen. It's 100% your code as
far as I'm concerned, I'm just preventing this automated process from changing
apparent authorship to me (which I feel would be more dishonest than this extremely
minor way that I am sort of forging a commit in your name.)

In addition to the clang-format reformatting, I've also taken the liberty of making most of
these files conform to our blank space conventions -- three blank lines between freestanding
function implementations, never more than one blank line in a row INSIDE a function,
and no blank lines immediately after an opening brace or immediately before a closing
brace. That is beyond the domain of clang-format, but I think those conventions promote
clear visual parsing (at least by me) of the code layout.

Copy link
Contributor

@sfriedmapixar sfriedmapixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AlexMWells AlexMWells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz lgritz closed this May 16, 2022
@lgritz lgritz deleted the lg-clangformat branch May 16, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants