Constant folding of startswith() #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have constant folded endswith() for a long time. Dunno why we overlooked startswith, but here it is. Signed-off-by: Larry Gritz <[email protected]>
fpsunflower
approved these changes
May 13, 2022
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
May 13, 2022
We have constant folded endswith() for a long time. Dunno why we overlooked startswith, but here it is. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have constant folded endswith() for a long time. Dunno why we
overlooked startswith, but here it is.
Also simplified endswith to use Strutil::ends_with instead of replicating
the logic here for no good reason.
Signed-off-by: Larry Gritz [email protected]