Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for memory error on teardown of testrender due to late destructio… #1499

Merged
merged 2 commits into from
May 4, 2022
Merged

Fix for memory error on teardown of testrender due to late destructio… #1499

merged 2 commits into from
May 4, 2022

Conversation

sfriedmapixar
Copy link
Contributor

@sfriedmapixar sfriedmapixar commented May 3, 2022 •
edited
Loading

…n of shader shared pointers.

Signed-off-by: Stephen Friedman [email protected]

Description

Tests

Checklist:

  • I have read the contribution guidelines.
  • I have previously submitted a Contributor License Agreement.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

AlexMWells
AlexMWells approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@AlexMWells AlexMWells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz lgritz merged commit 880b446 into AcademySoftwareFoundation:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgritz lgritz lgritz approved these changes

@AlexMWells AlexMWells AlexMWells approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfriedmapixar @lgritz @AlexMWells