Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More conversion of internals to std::format style, bit by bit #1493

Merged
merged 1 commit into from
May 4, 2022

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Apr 19, 2022

There's no rhyme or reason to this particular set of changes... I just
picked a few files and did the obvious conversion. Will do more in
subsequent PRs.

Signed-off-by: Larry Gritz [email protected]

@AlexMWells
Copy link
Contributor

Will be updating the batched version to use the new fmt stuff to keep it similar?

@lgritz
Copy link
Collaborator Author

lgritz commented May 2, 2022

@AlexMWells Yes. I'm just doing a little at a time to keep it manageable, and trying to work where I don't think others are in the middle of major work on those same files.

Copy link
Contributor

@AlexMWells AlexMWells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There's no rhyme or reason to this particular set of changes... I just
picked a few files and did the obvious conversion. Will do more in
subsequent PRs.

Signed-off-by: Larry Gritz <[email protected]>
@lgritz lgritz merged commit 3d00dbc into AcademySoftwareFoundation:main May 4, 2022
@lgritz lgritz deleted the lg-fmt branch May 4, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants