-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OptiX matrix fixes #1485
OptiX matrix fixes #1485
Conversation
8dce1ea
to
efc8d06
Compare
…es are regenerated whenever those headers are changed. Signed-off-by: Tim Grant <[email protected]>
Signed-off-by: Tim Grant <[email protected]>
…n the OptiX wrappers. Signed-off-by: Tim Grant <[email protected]>
Signed-off-by: Tim Grant <[email protected]>
…ndled correctly. Signed-off-by: Tim Grant <[email protected]>
Signed-off-by: Tim Grant <[email protected]>
Signed-off-by: Tim Grant <[email protected]>
efc8d06
to
1116602
Compare
Hopefully this does not conflict too drastically with #1494. |
I don't think they have any conflicts, I think testshade and its CMakeList.txt are only files in common, so a merge/rebase might be necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for taking a look, Alex. |
I just verified that those two PRs can be merged atop each other without conflict. Will merge this now. |
Description
This PR adds very basic support for named transforms to testrender and testshade. It's a linear scan through a list of transform names to find the corresponding matrix. Although this is a far-from-ideal solution for real world scenarios with many named transforms, it is sufficient to enable further testing and development.
Tests
No new tests have been added, but all previously-passing tests still pass. It would be possible to enable the matrix tests in the testsuite if not for some small differences in error reporting:
CPU:
GPU:
Checklist: