Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR/BatchedFpTests #1456

Merged
merged 3 commits into from
Jan 25, 2022
Merged

PR/BatchedFpTests #1456

merged 3 commits into from
Jan 25, 2022

Conversation

AlexMWells
Copy link
Contributor

Description

Implement batched versions of isnan, isinf, and isfinite.

Tests

Added batched regression testsuite ieee-fp-reg.

NOTE: its really difficult to test isnan(value) == true,
as its unclear to actually generate a NAN in OSL because
most functions are "safe" and check/avoid NAN's

Checklist:

  • I have read the contribution guidelines.
  • I have previously submitted a Contributor License Agreement.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

@AlexMWells
Implement batched versions of isnan, isinf, and isfinite.
4058343 
Added batched regression testsuite ieee-fp-reg.

NOTE:  its really difficult to test isnan(value) == true,
as its unclear to actually generate a NAN in OSL because
most functions are "safe" and check/avoid NAN's

Signed-off-by: Alex M. Wells <[email protected]>
@AlexMWells
Add new files missed in original commit
e07b7ec 
Signed-off-by: Alex M. Wells <[email protected]>
@AlexMWells
Applied clang-format to new files
db58741 
Signed-off-by: Alex M. Wells <[email protected]>
@AlexMWells AlexMWells requested a review from lgritz January 24, 2022 21:49
lgritz
lgritz approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz lgritz merged commit 72acb7c into AcademySoftwareFoundation:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgritz lgritz lgritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexMWells @lgritz