RuntimeOptimizer: Fix messages & unknown_message_sent initialization #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex Wells pointed out that they were never explicitly initialized. Signed-off-by: Larry Gritz <[email protected]>
lgritz
referenced
this pull request
Dec 14, 2021
including if a non-constant named message is ever set (could be anything). Then for getmessage() of a known name, if it couldn't possibly have been set, turn the getmessage into simply an assignment of 0 to the result (not found). This saves 10% of total render time on our favorite production benchmark! Lots of our production shaders check for messages that trigger special behavior (usually for debugging), but apparently it's rarely set. Not only do we save the trouble of doing the getmessage() in these cases, but often the absence of the message allows us to get rid of entire "if" clauses of code that won't be used for this shader instance. http://codereview.appspot.com/1106041/show Review by: ckulla git-svn-id: https://openshadinglanguage.googlecode.com/svn/trunk@625 a3683778-fedd-11de-87c3-653bb6514e15
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Dec 28, 2021
…cademySoftwareFoundation#1447) Alex Wells pointed out that they were never explicitly initialized. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alex Wells pointed out that they were never explicitly initialized.
Signed-off-by: Larry Gritz [email protected]