Bump LLVM minimum from 7 to 9 #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Among other cruft that existed to support versions 7 and 8, this lets us completely get rid of PrePromoteLogicalOpsOnBitMasks custom pass, which is only needed for LLVM < 8. Also get rid of some cmake checks for LLVM versions that require C++14 or higher -- not necessary now that C++14 is our minimum. Signed-off-by: Larry Gritz <[email protected]>
AlexMWells
approved these changes
Nov 24, 2021
|
This is only future releases, won't be backported to the current release branch. There are no "pitfalls", it's a hard error when compiling llvm_util.cpp to have a version of LLVM that is < 9.0. We cleared this a couple months back, both on the mail list and in the TSC, and there were no objections. I was just waiting for some changes to the aswf-docker containers, which had a couple of the VFX Platform year containers that lacked a sufficiently new LLVM, so I didn't want to push forward with this approved change it was going to break our CI. But that was recently fixed with the Conan build availability. |
fpsunflower
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other cruft that existed to support versions 7 and 8, this lets
us completely get rid of PrePromoteLogicalOpsOnBitMasks custom pass,
which is only needed for LLVM < 8.
Also get rid of some cmake checks for LLVM versions that require
C++14 or higher -- not necessary now that C++14 is our minimum.
Signed-off-by: Larry Gritz [email protected]